Ignore start_pts only for mp3 files #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbreyfogle
approved these changes
Feb 1, 2024
|
For lining, looks like the version of |
…mports incompatibility
vickianand
reviewed
Feb 1, 2024
vickianand
approved these changes
Feb 1, 2024
anjoola
force-pushed
the
angela/ed-19914-studio-sound-is-ignoring-start_pts-0027-seconds
branch
from
73fd62b to
7a29c3c
Compare
aluebs
reviewed
Feb 1, 2024
aluebs
approved these changes
Feb 1, 2024
anjoola
deleted the
angela/ed-19914-studio-sound-is-ignoring-start_pts-0027-seconds
branch
anjoola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Linear ticket, it looks like we only should be ignoring start_pts < 0.027 for mp3 files. So let's check for that first